Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow injected dependencies when subspaces are disabled #5057

Conversation

aramissennyeydd
Copy link
Contributor

Summary

Original question in Zulip: https://rushstack.zulipchat.com/#narrow/channel/262513-general/topic/Injected.20Dependencies.20and.20Subspaces/near/490904453

I'm trying to enable injected dependencies and was getting some confusing error messages (and a lack of repo-state.json changes) that indicated something wasn't updating as it should have. Looks like injected dependencies were gated at some point between subspaces and I can't see a great reason why they should be.

Details

Remove check for having subspaces enabled when using injected dependencies.

How it was tested

Tested in our repository that the repo-state file had changes after running rush update and that subsequent runs were cached.

Impacted documentation

Signed-off-by: Aramis Sennyey <[email protected]>
Copy link
Collaborator

@octogonz octogonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@octogonz octogonz merged commit a63054f into microsoft:main Dec 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants