[rush] Treat disabled noops as noop instead of skipped #5043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
D4N14L
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that noops don't block cache writing, even if they are disabled.
Details
During phased command execution, if a disabled operation is identified as a No-Op, return
OperationStatus.NoOpinstead ofOperationStatus.Skipped, since by definition a No-Op should not write any files.How it was tested
Fiddled with command-line.json so that
@rushstack/eslint-patchwould depend on a noop in@rushstack/tree-pattern, then ranrush build -o eslint-patch --verboseand verified that it wrote a cache entry.Impacted documentation
None, since this is expected.