Support fallback syntax in .npmrc file #5030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzxen
force-pushed
the
feature/support_fallback_syntax_in_npmrc
branch
from
64956bc to
0a5655e
Compare
fzxen
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
reviewed
Dec 6, 2024
fzxen
force-pushed
the
feature/support_fallback_syntax_in_npmrc
branch
2 times, most recently
from
6395103 to
32020cc
Compare
iclanton
reviewed
Dec 10, 2024
fzxen
force-pushed
the
feature/support_fallback_syntax_in_npmrc
branch
from
32020cc to
d7aa2ed
Compare
iclanton
approved these changes
Dec 10, 2024
D4N14L
approved these changes
Dec 10, 2024
iclanton
reviewed
Dec 10, 2024
common/changes/@microsoft/rush/feature-support_fallback_syntax_in_npmrc_2024-12-04-13-22.json
Outdated
Show resolved
Hide resolved
D4N14L
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5029
Details
I added a regular expression which copies from @pnpm/config.env-replace/env-replace.ts for identifying fallback syntax.
How it was tested
I added some test cases in the
libraries/rush-lib/src/utilities/test/npmrcUtilities.test.tsfile to ensure the rush work goes as expected.