Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Add option to suppress hardcoded npmjs.org registry call #4900

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

dmichon-msft
Copy link
Contributor

@dmichon-msft dmichon-msft commented Aug 22, 2024

Summary

Add a new option to rush.json "suppressRushIsPublicVersionCheck" that disables a hardcoded call to the public npmjs.org registry to validate that the executing version of Rush (according to package.json) matches one that has been published to the public registry.

This feature is to support enterprises that run Rush on machines that they are denying access to npmjs.org.

Details

Also defer loads the WebClient wrapper around node-fetch to reduce startup time.

Updated rush-init template to include the setting.

How it was tested

Walked through rush install under debugger and validated that the condition hit both branches depending on the setting in rush.json.

Impacted documentation

Docs for rush.json

@iclanton iclanton merged commit 3ed14b7 into main Aug 23, 2024
4 checks passed
@iclanton iclanton deleted the user/dmichon/suppress-registry-call branch August 23, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants