[workspace-resolve-plugin] Create plugin for more efficient resolution when repo structure is known #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
TheLarkInn and
patmill
as code owners
iclanton
reviewed
Aug 12, 2024
webpack/webpack-workspace-resolve-plugin/src/KnownDescriptionFilePlugin.ts
Show resolved
Hide resolved
webpack/webpack-workspace-resolve-plugin/src/KnownDescriptionFilePlugin.ts
Outdated
Show resolved
Hide resolved
webpack/webpack-workspace-resolve-plugin/src/WorkspaceLayoutCache.ts
Outdated
Show resolved
Hide resolved
webpack/webpack-workspace-resolve-plugin/src/WorkspaceLayoutCache.ts
Outdated
Show resolved
Hide resolved
webpack/webpack-workspace-resolve-plugin/src/WorkspaceLayoutCache.ts
Outdated
Show resolved
Hide resolved
dmichon-msft
commented
Aug 13, 2024
iclanton
approved these changes
Aug 13, 2024
iclanton
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Defines a webpack plugin that accelerates module resolution in webpack by leveraging the known installation layout of a monorepo.
This plugin is not a standalone and depends on external tooling that talks to the package manager of choice to generate the necessary cache file.
Details
Plugin improves resolver performance by assuming that the following data are immutable during a build and can be efficiently precalculated using data from the package manager:
package.jsonfiles in the repo and its installed dependencies, including any used to configure subfoldersHow it was tested
Unit tests for the algorithm.
Impacted documentation
Only its own.