[localization-utilities] Update the .loc.json schema to allow for string names that include the '$' character. #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
…lude the '$' character.
D4N14L
reviewed
Aug 12, 2024
libraries/localization-utilities/src/schemas/locJson.schema.json
Outdated
Show resolved
Hide resolved
D4N14L
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
$character to the schema for.loc.jsonstring names. The$character is allowed in JavaScript variable names.How it was tested
https://jsbench.me/wxlsb1hcmr/1Consideration, this is about 20% slower.Revised the approach to add an API to node-core-library's
JsonSchemavalidation to ignore the$schemaproperty.