[rush] Fix an issue that rush-pnpm patch-commit can not generate correct pnpm-config.json file in subspace case
#4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-chao
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
reviewed
Jul 17, 2024
common/changes/@microsoft/rush/chao-fix-rush-pnpm-patch_2024-07-17-20-42.json
Outdated
Show resolved
Hide resolved
octogonz
approved these changes
Jul 19, 2024
…-pnpm-patch # Conflicts: # common/config/rush/version-policies.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make sure
rush-pnpm patch-commitgenerate changes into subspace pnpm-config.json file not the default ones in subspace case.How it was tested
Tested with a local Monorepo