Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lockfile-explorer] Add version validation capability (reopened) #4779
[lockfile-explorer] Add version validation capability (reopened) #4779
Changes from 20 commits
ce81faf
7f00302
c2e86bf
024991f
c57a379
f679d5d
b76e991
086ed9e
45ea1ce
aca2678
1e9a4d5
7286123
ebbd0e9
d8f9d65
145fc35
465550d
72d1c07
7b9ee9d
1181731
d93ded1
c5e2558
e8c330e
f81bc2f
afd250e
84e55e8
9230d3b
2ff2dbf
fa72086
cf8c73e
7bb89ab
9ee2f68
1fa898f
2f08459
ff67723
a746dac
e1e693c
f8ca49c
e11978a
2602025
9f1f293
7b85ca7
ec9a99c
797868e
d63f320
126e8ee
3a647f6
b20466c
5477bbc
689d243
8094f14
8e08d5c
f0cb469
9f571ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make this comparison without using
path.resolve
? Functions onpath
are somewhat slow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use
path.resolve
here, using other methods might be a bit hackyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like these results should be cached, as multiple projects can point at the same dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same dependency is never checked twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should collect all of the projects that are to be validated by this rule and then run them all together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can specify multiple constrained versions for the same project and analyze these dependencies together
"rules": [
{
"rule": "restrict-versions",
"project": "A",
"requiredVersions": {
"react-router": "^4",
"react": "18.2.0"
}
}
]