[ts-command-line] Improve API typings #4554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
octogonz
changed the title
iclanton
force-pushed
the
ts-command-line-tweaks
branch
from
845d883 to
1144ec0
Compare
octogonz
reviewed
Feb 28, 2024
octogonz
approved these changes
Feb 28, 2024
iclanton
force-pushed
the
ts-command-line-tweaks
branch
from
1144ec0 to
edaca3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes to minor changes to ts-command-line's types:
define___Parameterfunctions when the{ required: true }option is passed which returns a new type with a non-nullablevalueproperty. This avoids needing a non-null assertion when the required value is used.How it was tested
Updated consuming projects to use these new types.
Impacted documentation
API docs will need to be updated.