Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[install-test-workspace] Improve test to catch more phantom dependencies #4528

Merged
merged 8 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions build-tests/install-test-workspace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
},
"devDependencies": {
"@microsoft/rush-lib": "workspace:*",
"@rushstack/node-core-library": "workspace:*",
"@rushstack/rush-sdk": "workspace:*",
"@rushstack/terminal": "workspace:*"
"@rushstack/node-core-library": "workspace:*"
}
}
28 changes: 28 additions & 0 deletions build-tests/install-test-workspace/workspace/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Rush uses this file to configure the NPM package registry during installation. It is applicable
# to PNPM, NPM, and Yarn package managers. It is used by operations such as "rush install",
# "rush update", and the "install-run.js" scripts.
#
# NOTE: The "rush publish" command uses .npmrc-publish instead.
#
# Before invoking the package manager, Rush will copy this file to the folder where installation
# is performed. The copied file will omit any config lines that reference environment variables
# that are undefined in that session; this avoids problems that would otherwise result due to
# a missing variable being replaced by an empty string.
#
# * * * SECURITY WARNING * * *
#
# It is NOT recommended to store authentication tokens in a text file on a lab machine, because
# other unrelated processes may be able to read the file. Also, the file may persist indefinitely,
# for example if the machine loses power. A safer practice is to pass the token via an
# environment variable, which can be referenced from .npmrc using ${} expansion. For example:
#
# //registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}
#
registry=https://registry.npmjs.org/
always-auth=false
# No phantom dependencies allowed in this repository
# Don't hoist in common/temp/node_modules
public-hoist-pattern=
# Don't hoist in common/temp/node_modules/.pnpm/node_modules
hoist=false
hoist-pattern=

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"@microsoft/rush-lib": "*",
"colors": "^1.4.0"
"@rushstack/terminal": "*"
},
"devDependencies": {
"@types/node": "18.17.15",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ import { ConsoleTerminalProvider, Terminal } from '@rushstack/terminal';

const terminal = new Terminal(new ConsoleTerminalProvider());
VersionMismatchFinder.ensureConsistentVersions(config, terminal);

console.log(new ConsoleTerminalProvider().supportsColor);
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"start": "node lib/start.js"
},
"dependencies": {
"@rushstack/rush-sdk": "*",
"colors": "^1.4.0"
"@rushstack/rush-sdk": "*"
},
"devDependencies": {
"@microsoft/rush-lib": "*",
Expand Down
6 changes: 0 additions & 6 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading