[set-webpack-public-path-plugin] Add a second plugin that uses the document.currentScript API. #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
TheLarkInn
as code owners
dmichon-msft
approved these changes
Jan 16, 2024
webpack/set-webpack-public-path-plugin/src/SetPublicPathCurrentScriptPlugin.ts
Outdated
Show resolved
Hide resolved
webpack/set-webpack-public-path-plugin/src/SetPublicPathPlugin.ts
Outdated
Show resolved
Hide resolved
webpack/set-webpack-public-path-plugin/src/SetPublicPathPlugin.ts
Outdated
Show resolved
Hide resolved
webpack/set-webpack-public-path-plugin/src/SetPublicPathPlugin.ts
Outdated
Show resolved
Hide resolved
iclanton
force-pushed
the
currentScript-approach
branch
from
7bff259 to
9bd6284
Compare
iclanton
force-pushed
the
currentScript-approach
branch
from
9bd6284 to
a7238bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a second plugin to this package that wraps the bundle in an IIFE to record the
document.currentScriptproperty before the factory function is called and then use that variable to set the__webpack_public_path__variable.How it was tested
Tested in a large monorepo.
Impacted documentation
The second mode needs to be documented.