[heft-typescript] Fix updateShapeSignature break #4471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
dmichon-msft
force-pushed
the
heft-typescript-dts-map-fix
branch
from
2f7f200 to
4d77148
Compare
D4N14L
approved these changes
Jan 2, 2024
|
🚀 Released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4224
Fixes #4470
Details
Program#emitcontains an additional parameterforceDtsEmitthat is not in the published types, and is passed during shape signature computation. Heft was not forwarding this parameter when overriding the program, resulting in behavior changes.How it was tested
Local repro of the issue in #4224. Running
heft-webpack5-everything-testin watch mode and changingclass ChunkClassinChunkClass.tstoclass Chunk Class.Impacted documentation
None