-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Add installation for subspaces #4458
Merged
octogonz
merged 66 commits into
microsoft:main
from
william2958:will/install-subspace-cont
Jan 30, 2024
Merged
[rush] Add installation for subspaces #4458
octogonz
merged 66 commits into
microsoft:main
from
william2958:will/install-subspace-cont
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ian Clanton-Thuon <[email protected]>
william2958
force-pushed
the
will/install-subspace-cont
branch
from
December 21, 2023 15:15
76ac6b7
to
a3d449e
Compare
william2958
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
December 21, 2023 18:44
Note that the ignore-scripts PR features have been removed from this PR to separate the concerns. There appears to be more design decisions and reviews required the the other PR, so this PR is just to update the way rush looks for configuration files and where it installs dependencies to support subspaces. |
octogonz
reviewed
Jan 27, 2024
libraries/rush-lib/src/logic/pnpm/SubspacePnpmfileConfiguration.ts
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Jan 27, 2024
Refactor to replace "subspaceName" with a Subspace class
for (let i=0;i<rushConfiguration.subspaces.length;++i) { console.log(rushConfiguration.subspaces[i].subspaceName) }
octogonz
reviewed
Jan 30, 2024
octogonz
reviewed
Jan 30, 2024
octogonz
reviewed
Jan 30, 2024
…te() API more intuitive
…am2958/rushstack into will/install-subspace-cont
octogonz
reviewed
Jan 30, 2024
… was subspacesFeatureEnabled passed instead of splitWorkspaceCompatibility
octogonz
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR adds the ability to install dependencies for a subspace.
Details
This MR adds the following changes:
common/config/subspaces/first_subspace
as opposed to the defaultcommon/config
splitWorkspaceCompatibility
option in the subspace configuration, which allows subspaces to specify their configuration files under the project folder itself if it is the only project in a subspace. For example, if projecta
is the only project in subspacefirst_subspace
, it can have it's configuration files under the foldera/subspace/first_subspace
instead of the defaultcommon/config/subspaces/first_subspace
folder./temp/first_subspace
folder as opposed to the default/temp
folder--subspace <subspace_name>
for the commandsrush install
andrush update
to install for a specific subspace.Add support for filtered installs (using selectors like--to
,--from
, etc.) by installing all affected subspaces sequentially.rush build -o subspace:first_subspace
How it was tested
Impacted documentation
Rush operation should be completely unaffected if the subspaces feature not enabled.
However since the feature is close to code complete, we're going to start work on website docs soon.