-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node-core-library] Add ability to list processes on Windows and Unix-based platforms #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D4N14L
requested review from
iclanton,
octogonz,
apostolisms and
dmichon-msft
as code owners
December 5, 2023 21:20
D4N14L
changed the title
[node-core-library] Add ability to list processes on win32 and unix-based platforms
[node-core-library] Add ability to list processes on Windows and Unix-based platforms
Dec 5, 2023
dmichon-msft
reviewed
Dec 5, 2023
dmichon-msft
reviewed
Dec 5, 2023
dmichon-msft
reviewed
Dec 6, 2023
iclanton
reviewed
Dec 6, 2023
common/changes/@rushstack/node-core-library/user-danade-ListProcesses_2023-12-05-21-20.json
Outdated
Show resolved
Hide resolved
iclanton
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the ability to list out processes and their child process tree for Windows and Unix-based systems.
Details
While there exists a few different tools that can accomplish similar tasks (ex.
ps-tree
,ps-list
), these tools are missing some functionality. For example,ps-tree
is able to return the child tree of a specific process ID, but is unable to list out all processes.ps-list
can list out all processes, but does not build a child tree. Additionally,ps-list
is not bundlable due to it's dependency on thefastlist
binary on Windows.This PR brings all this functionality under the same method.
How it was tested