Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-patch] Fix patch compatibility with ESLint >=7.0.0 and <7.12.0 #4374

Merged
merged 7 commits into from
Sep 30, 2023

Conversation

D4N14L
Copy link
Member

@D4N14L D4N14L commented Sep 30, 2023

Summary

Changes made in #4353 introduced compatibility issues with a specific range of ESLint 7 versions. This was caused by two different issues:

  • a change in the logic which was an attempt to improve the speed of resolution of the required modules, and
  • the naming module being moved from the standard eslint package to the @eslint/eslintrc package in 7.8.0, before the larger change to move the config-array-factory module there as well in 7.12.0.

This change fixes both issues, and adds new test projects for [email protected] and [email protected] to ensure that this issue does not arise again.

Fixes #4368

How it was tested

Added new test projects and confirmed that the patch is correctly consumed.

@octogonz octogonz enabled auto-merge September 30, 2023 04:46
@octogonz octogonz merged commit 9ce7570 into microsoft:main Sep 30, 2023
5 checks passed
@iclanton iclanton deleted the user/danade/FixEslint7 branch February 26, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[@rushstack/eslint-patch] v1.5.0 - The "id" argument must be of type string. Received undefined
3 participants