-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-extractor] Add a new message "ae-undocumented" #4370
Conversation
This is great, thank you so much for this PR! Testing TBDocs Report 🛑 Errors: 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, worked as intended for my goals and reviewing the code it makes sense to me (but take it with huge grains of salt, since I'm not familiar with the repo).
Thank you so much for the support on this PR.
…ndocumented # Conflicts: # build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml
@leordev this was released with API Extractor 7.38.0 🚀 |
@octogonz I just realized that this is also warning non exposed members, in my particular case private class members:
This is my class definition: export class MyClass<T> {
private _metadata: ResourceMetadata<T>
private _data: ResourceKindModel<T>
private _signature: string
// ...
} Is it possible to set it only for exposed APIs? Maybe through configuration? |
This is a bug. It is not intentional behavior. |
Here is a fix: #4392 |
Summary
Requested in this Zulip thread.
Although API Extractor already flags undocumented items in the .api.md file as
// (undocumented)
, @leordev wants to detect them via theExtractor.invoke()
API for CI validation.How it was tested
The
ae-undocumented
message defaults tologLevel=none
, so I modified a test project to uselogLevel=warning
and confirmed that it is printed correctly.Impacted documentation
Need to add this message to the website.