Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Fix filtered installs in pnpm@8 #4344

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

dmichon-msft
Copy link
Contributor

Summary

Fixes #4285

Details

Sets the dedupe-peer-dependents=false option when passing filter arguments and installing with --frozen-lockfile.

How it was tested

Created a second git worktree and used the modified version of rush to run rush install --to @rushstack/heft:

Running "pnpm install" in /workspaces/rushstack-2/common/temp

Scope: 14 of 130 workspace projects
Lockfile is up to date, resolution step is skipped
.                                        | +507 +++++++++++++++++++++++++++++++++++++++++++++++++++

Downloading registry.npmjs.org/typescript/5.0.4: 7.05 MB/7.05 MB, done
Progress: resolved 507, reused 0, downloaded 497, added 507, done
Done in 2.8s

Impacted documentation

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[rush] installing "to" a workspace project still installs all packages for all projects (using pnpm v8)
2 participants