[rush-lib] Add experiment flag to allow skipping build with warning

common/changes/@microsoft/rush/feat-skip-build-with-warning-status_2023-09-20-06-34.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Add experiment `buildSkipWithAllowWarningsInSuccessfulBuild` to allow skipping builds that succeeded with warnings in the previous run.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}

common/config/rush/experiments.json

@@ -36,6 +36,12 @@
    */
   // "buildCacheWithAllowWarningsInSuccessfulBuild": true,
 
+  /**
+   * If true, build skipping will respect the allowWarningsInSuccessfulBuild flag and skip builds with warnings.
+   * This will not replay warnings from the skipped build.
+   */
+  // "buildSkipWithAllowWarningsInSuccessfulBuild": true,
+
   /**
    * If true, the phased commands feature is enabled. To use this feature, create a "phased" command
    * in common/config/rush/command-line.json.

common/reviews/api/rush-lib.api.md

@@ -444,6 +444,7 @@ export interface IExecutionResult {
 // @beta
 export interface IExperimentsJson {
     buildCacheWithAllowWarningsInSuccessfulBuild?: boolean;
+    buildSkipWithAllowWarningsInSuccessfulBuild?: boolean;
     cleanInstallAfterNpmrcChanges?: boolean;
     forbidPhantomResolvableNodeModulesFolders?: boolean;
     noChmodFieldInTarHeaderNormalization?: boolean;

libraries/rush-lib/src/api/ExperimentsConfiguration.ts

@@ -49,6 +49,12 @@ export interface IExperimentsJson {
    */
   buildCacheWithAllowWarningsInSuccessfulBuild?: boolean;
 
+  /**
+   * If true, build skipping will respect the allowWarningsInSuccessfulBuild flag and skip builds with warnings.
+   * This will not replay warnings from the skipped build.
+   */
+  buildSkipWithAllowWarningsInSuccessfulBuild?: boolean;
+
   /**
    * If true, the phased commands feature is enabled. To use this feature, create a "phased" command
    * in common/config/rush/command-line.json.

libraries/rush-lib/src/cli/scriptActions/PhasedScriptAction.ts

@@ -363,6 +363,9 @@ export class PhasedScriptAction extends BaseScriptAction<IPhasedCommandConfig> {
       } else if (!this._disableBuildCache) {
         // Explicitly disabling the build cache also disables legacy skip detection.
         new LegacySkipPlugin({
+          allowWarningsInSuccessfulBuild:
+            this.rushConfiguration.experimentsConfiguration.configuration
+              .buildSkipWithAllowWarningsInSuccessfulBuild,
           terminal,
           changedProjectsOnly,
           isIncrementalBuildAllowed: this._isIncrementalBuildAllowed

libraries/rush-lib/src/logic/operations/LegacySkipPlugin.ts

@@ -55,6 +55,7 @@ export interface ILegacySkipPluginOptions {
   terminal: ITerminal;
   changedProjectsOnly: boolean;
   isIncrementalBuildAllowed: boolean;
+  allowWarningsInSuccessfulBuild?: boolean;
 }
 
 /**
@@ -72,7 +73,8 @@ export class LegacySkipPlugin implements IPhasedCommandPlugin {
 
     let projectChangeAnalyzer!: ProjectChangeAnalyzer;
 
-    const { terminal, changedProjectsOnly, isIncrementalBuildAllowed } = this._options;
+    const { terminal, changedProjectsOnly, isIncrementalBuildAllowed, allowWarningsInSuccessfulBuild } =
+      this._options;
 
     hooks.createOperations.tap(
       PLUGIN_NAME,
@@ -257,7 +259,14 @@ export class LegacySkipPlugin implements IPhasedCommandPlugin {
 
         const { packageDeps, packageDepsPath } = skipRecord;
 
-        if ((packageDeps && status === OperationStatus.Success) || status === OperationStatus.NoOp) {
+        if (
+          status === OperationStatus.NoOp ||
+          (packageDeps &&
+            (status === OperationStatus.Success ||
+              (status === OperationStatus.SuccessWithWarning &&
+                record.operation.runner!.warningsAreAllowed &&
+                allowWarningsInSuccessfulBuild)))
+        ) {
           // Write deps on success.
           await JsonFile.saveAsync(packageDeps, packageDepsPath, {
             ensureFolderExists: true

libraries/rush-lib/src/schemas/experiments.schema.json

@@ -34,6 +34,10 @@
       "description": "If true, build caching will respect the allowWarningsInSuccessfulBuild flag and cache builds with warnings. This will not replay warnings from the cached build.",
       "type": "boolean"
     },
+    "buildSkipWithAllowWarningsInSuccessfulBuild": {
+      "description": "If true, build skipping will respect the allowWarningsInSuccessfulBuild flag and skip builds with warnings. This will not replay warnings from the skipped build.",
+      "type": "boolean"
+    },
     "phasedCommands": {
       "description": "If true, the phased commands feature is enabled. To use this feature, create a \"phased\" command in common/config/rush/command-line.json.",
       "type": "boolean"