Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[heft-sass-plugin] Upgrade postcss-modules #4297

Merged
merged 2 commits into from
Dec 8, 2023
Merged

[heft-sass-plugin] Upgrade postcss-modules #4297

merged 2 commits into from
Dec 8, 2023

Conversation

kamontat
Copy link
Contributor

No description provided.

@iclanton
Copy link
Member

What testing have you done on this? What changed in postcss-modules in those five major bumps?

@iclanton iclanton changed the title Upgrade postcss-modules [heft-sass-plugin] Upgrade postcss-modules Aug 28, 2023
@kamontat
Copy link
Contributor Author

kamontat commented Sep 7, 2023

@iclanton Below are the changes collected from CHANGELOG

  • For v2.0.0: remove camelCase key which we didn't use.
  • For v3.0.0: dropped Node v8 and v9 support.
  • For v4.0.0: upgraded to PostCSS 8 which we already use.
  • For v5.0.0: upgrade babel to v7.
  • For v6.0.0: change function resolve signature which we didn't use.

Sorry for delay, I didn't check my GitHub account notification for some times.

@kamontat
Copy link
Contributor Author

Sync with main branch.

@kamontat kamontat requested a review from iclanton October 23, 2023 03:53
@octogonz
Copy link
Collaborator

octogonz commented Dec 8, 2023

@iclanton is this PR ready to merge?

kamontat and others added 2 commits December 8, 2023 11:13
@iclanton iclanton force-pushed the feature/upgrade-postcss-modules branch from 5b4e734 to 62b223a Compare December 8, 2023 19:15
@iclanton iclanton enabled auto-merge December 8, 2023 19:16
@iclanton iclanton merged commit 1085e78 into microsoft:main Dec 8, 2023
5 checks passed
@kamontat kamontat deleted the feature/upgrade-postcss-modules branch December 10, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclanton iclanton iclanton approved these changes

@octogonz octogonz Awaiting requested review from octogonz octogonz is a code owner

@apostolisms apostolisms Awaiting requested review from apostolisms apostolisms is a code owner

@D4N14L D4N14L Awaiting requested review from D4N14L D4N14L is a code owner

@dmichon-msft dmichon-msft Awaiting requested review from dmichon-msft dmichon-msft is a code owner

@patmill patmill Awaiting requested review from patmill patmill is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Bug Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamontat @iclanton @octogonz