-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Add hooks for pre and post rushx events #4286
Merged
Merged
Changes from 28 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
bbba972
adding pre and post rushx events
nebosite bfff506
Adding Pro and Post event hooks to rushx
nebosite 6d29a0e
Move exitcode handling out of _lauchRushXInternal
nebosite 406fb69
Whoops accidentally checked in test code
nebosite d936b16
Special handling for process errors
nebosite 8050af6
Quote unknown arguments
nebosite 454e113
Rename INSIDERUSH to _RUSH_SUPPRESS_HOOKS
nebosite 9517be9
Add debug parameter to rushx so it can be passed to hooks
nebosite 39d1011
Don't print hook suppressed messages on recursive calls
nebosite f8a0be2
Add --ignorehooks and fix bug in hook runner
nebosite 657eb84
Don't try to run hooks on --help
nebosite 3ba9901
responding to code reviews
nebosite 738b55f
Rush change
nebosite 327fbe4
Merge remote-tracking branch 'remotes/origin/main' into neboste/rushx…
octogonz 3815b1a
Fix some build warnings
octogonz c89d1dc
Fix a test failure (but I have some questions about this variable, se…
octogonz a93c500
Add more detail to change file
octogonz 3d406c6
Document event hooks in rush.json template
octogonz ff5d1b9
Rename RUSH_SUPPRESS_HOOKS to _RUSH_SUPPRESS_RUSHX_HOOKS (because it …
octogonz 914ab21
Rename EnvironmentVariableNames.RUSH_LIB_PATH to _RUSH_LIB_PATH to ma…
octogonz aaee1f2
Remove "-i" parameter per PR discussion
octogonz 3065543
Refactor arguments to _launchRushXInternal
nebosite b7f94fd
Refactor environment variable name for hook suppression
nebosite ee01b51
Handle rushx hook errors as benign
nebosite 710af8a
rolling back accidental change to rush and rushx scripts
nebosite 2bd1390
Add environment var _RUSH_ORIGINAL_ARGS
nebosite 5618ca8
Rename _RUSH_ORIGINAL_ARGS to a public environment variable RUSH_INVO…
octogonz 6da0cf6
RUSH_INVOKED_ARGS should only be assigned when invoking hook scripts …
octogonz 125f25c
putting back alreadyReportedNodeTooNewError
nebosite 04c723d
rolling back accidental change to rush and rushx scripts
nebosite 9236fac
Merge branch 'neboste/rushx_hooks' of github.com:nebosite/rushstack i…
nebosite 00d2c19
make _launchRushXInternal private
nebosite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
#!/usr/bin/env node | ||
require('../lib/start.js') | ||
require('../lib/start.js'); |
10 changes: 10 additions & 0 deletions
10
common/changes/@microsoft/rush/neboste-rushx_hooks_2023-10-03-00-40.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"changes": [ | ||
{ | ||
"packageName": "@microsoft/rush", | ||
"comment": "Add start `preRushx` and `postRushx` event hooks for monitoring the `rushx` command", | ||
"type": "none" | ||
} | ||
], | ||
"packageName": "@microsoft/rush" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nebosite This is not correct. The
launchRushX()
is the entry point for therushx
CLI binary (via the VersionSelector system). The options such asalreadyReportedNodeTooNewError
are important features. We cannot simply discard them here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. I didn't think about the API. I'll fix it tongith.