[package-extractor] Fix package extractor filter for subdirectories of non-matching folders #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D4N14L
requested review from
iclanton,
octogonz,
apostolisms and
dmichon-msft
as code owners
TheLarkInn
approved these changes
Jun 26, 2023
octogonz
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Package extractor allows for providing filters to modify the list of files to extract. However, because the file system traversal analyzes both folders and files, patterns that specified a subfolder of a non-matching parent folder would not be traversed and would be excluded from the generated extraction. This change ensures that all folders are traversed and only files are matched against the filters.
For example, if
patternsToIncludeissrc/**/*, files within thesrcfolder would not actually be collected, sincesrcdoes not match the patternsrc/**/*itself, even though the files and folders within do match.How it was tested
Tested locally against the project that the issue was encountered in.