Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci.yml, rush.json] Add Node 18, drop Node 14 #4135

Closed
wants to merge 4 commits into from

Conversation

mikeharder
Copy link
Contributor

@mikeharder mikeharder commented May 30, 2023

Summary

How it was tested

The CI run for this PR should validate itself.

Impacted documentation

None

@mikeharder mikeharder changed the title [ci.yml] Update node versions Add Node 18 and 20 to supported and tested versions May 30, 2023
@mikeharder mikeharder changed the title Add Node 18 and 20 to supported and tested versions Add Node 18 and 20, drop Node 14 May 30, 2023
@mikeharder mikeharder changed the title Add Node 18 and 20, drop Node 14 Add Node 18, drop Node 14 May 30, 2023
@mikeharder mikeharder changed the title Add Node 18, drop Node 14 [ci.yml, rush.json] Add Node 18, drop Node 14 May 30, 2023
@mikeharder
Copy link
Contributor Author

Node 18 is failing some scenarios with this error:

--[ FAILURE: hashed-folder-copy-plugin-webpack4-test (build) ][ 4.17 seconds ]--

node:internal/crypto/hash:71
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:19)
    at Object.createHash (node:crypto:133:10)
    at module.exports (/home/runner/work/rushstack/rushstack/common/temp/node_modules/.pnpm/[email protected]/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/home/runner/work/rushstack/rushstack/common/temp/node_modules/.pnpm/[email protected]/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/home/runner/work/rushstack/rushstack/common/temp/node_modules/.pnpm/[email protected]/node_modules/webpack/lib/NormalModule.js:471:10)
  ...2 lines omitted...
    at /home/runner/work/rushstack/rushstack/common/temp/node_modules/.pnpm/[email protected]/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/home/runner/work/rushstack/rushstack/common/temp/node_modules/.pnpm/[email protected]/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at Array.<anonymous> (/home/runner/work/rushstack/rushstack/common/temp/node_modules/.pnpm/[email protected]/node_modules/loader-runner/lib/LoaderRunner.js:205:4) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

@dmichon-msft
Copy link
Contributor

Webpack 4 is not currently compatible with Node 18; this is a known issue. We'd need to either get fixes/workarounds into Webpack 4 or figure out how to disable the webpack 4 projects when running with Node 18.
@TheLarkInn for thoughts on Webpack 4.

@mikeharder
Copy link
Contributor Author

@dmichon-msft: I think it would also be nice to add Node 20, but this would require the rushstack repo to upgrade to pnpm@>=8.3.1.

@iclanton
Copy link
Member

Handled by #4330 and #4278

@iclanton iclanton closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants