-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci.yml, rush.json] Add Node 18, drop Node 14 #4135
Conversation
- Test all supported LTS and "current" versions
Node 18 is failing some scenarios with this error:
|
Webpack 4 is not currently compatible with Node 18; this is a known issue. We'd need to either get fixes/workarounds into Webpack 4 or figure out how to disable the webpack 4 projects when running with Node 18. |
@dmichon-msft: I think it would also be nice to add Node 20, but this would require the |
Summary
pnpm@>=8.3.1
("ERR_INVALID_THIS" on "pnpm up" in Node 20 pnpm/pnpm#6424), so the rushstack repo would need to upgrade pnpm inrush.json
How it was tested
The CI run for this PR should validate itself.
Impacted documentation
None