-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Exposing executionRecords in PhasedScriptsAction allows users to observe the execution process #4010
[rush] Exposing executionRecords in PhasedScriptsAction allows users to observe the execution process #4010
Conversation
I needed a way to expose this data in #3651 as well, and at the time it seemed more useful to add an additional hook to I'd prefer not to add additional API surface to the PhasedScriptAction class and have any extensibility mechanisms be via the PhasedOperationHooks object for consistency. |
861f1d1
to
9ca56d6
Compare
a559bd5
to
4d21375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid floating promise issues. Either await async hooks or use sync hooks, depending on if it makes sense for the given hook to potentially modify state.
Edit: otherwise, looks about ready.
libraries/rush-lib/src/logic/operations/OperationExecutionManager.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/OperationExecutionManager.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/OperationExecutionManager.ts
Outdated
Show resolved
Hide resolved
6550166
to
5d05d6e
Compare
5d05d6e
to
d58485c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
common/changes/@microsoft/rush/feat-periodically-send-operation-state_2023-03-17-02-07.json
Outdated
Show resolved
Hide resolved
Co-authored-by: David Michon <[email protected]>
Summary
Exposing executionRecords in PhasedScriptsAction allows users to observe the execution process
Details
As a member of the monorepo infrastructure team, there will be many compilations in progress at the same time,
I hope to be able to collect the real-time status of the rush execution command. If I can get the real-time status in the hooks of rushLifeCycle, I can observe the start and end times of all project compilation in a task, and then send it to the data server to build a dashboard that can view the execution status in real time
How to use
Demo use local data