-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush-lib] react to pnpm v7 local install path breaking change #3908
[rush-lib] react to pnpm v7 local install path breaking change #3908
Conversation
In pnpm v7, the format of local installation paths and the hashing algorithm used to shorten paths have been changed. This PR add handling logic for pnpm v7.
7dce97f
to
cac2db7
Compare
Can we just use the |
Use `depPathToFilename()` from `dependency-path` instead of duplicating code.
@iclanton Good point. I made the change. As far as I know our repo doesn't have such cases that are impacted by the hasing change so I don't know how to test that. Also how do I test my PR in our repo? Previously I was just patching the js file under node_modules. |
You can test this change in your repo by running |
Thanks a lot! Tested with our repo on Linux/Windows. |
Summary
In pnpm v7, the format of local installation paths and the hashing algorithm used to shorten paths have been changed. It caused error described in #3652. This PR adds handling logic for pnpm v7.
Details
How it was tested
The code is tested using https://github.com/Azure/azure-sdk-for-js repository
Impacted documentation