[heft-webpack] Log nested errors/warnings #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLarkInn
approved these changes
Dec 1, 2022
dmichon-msft
force-pushed
the
webpack-nested-errors
branch
from
3f2ef31 to
2902c74
Compare
TheLarkInn
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that logging from webpack includes errors and warnings that originate in webpack child compiler instances.
Details
The stats
hasErrors()function includes errors from child compilations, but these errors don't get propagated into the top levelerrorsorwarningsarrays. This PR updates the Heft logger to also enumerate errors and warnings in all child compilations.How it was tested
Debugger validation of the location of nested errors.