[api-extractor] adding sort modifiers to union types in DtsRollupGenerator and ApiReportGenerator #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Generator and DtsRollupGenerator to avoid spurious reports
ajithAPER
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
|
|
@microsoft-github-policy-service agree [company="Atlassian"] |
|
@microsoft-github-policy-service agree company="Atlassian" |
…modifiers-for-union-spans-in-generators
|
@iclanton @octogonz @apostolisms @D4N14L Any recommended change for this PR ? |
ajithAPER
deleted the
api-extractor-sort-modifiers-for-union-spans-in-generators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #1958
Details
API reports and DTS rollouts generated show signs of spurious inferred union types between incremental build. This implementation simply introduces a sort modifier to sort all union type in DTS rollups and API reports.
How was it tested
Tested against reports within the repository generated automatically.