Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[loader-load-themed-styles] Make @microsoft/load-themed-styles a peerDependency of @microsoft/loader-load-themed-styles. #3656

Merged
merged 2 commits into from
Sep 28, 2022
Merged

[loader-load-themed-styles] Make @microsoft/load-themed-styles a peerDependency of @microsoft/loader-load-themed-styles. #3656

merged 2 commits into from
Sep 28, 2022

Conversation

iclanton
Copy link
Member

No description provided.

@iclanton iclanton enabled auto-merge September 28, 2022 00:35
@iclanton iclanton requested a review from patmill as a code owner September 28, 2022 00:45
D4N14L
D4N14L approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@D4N14L D4N14L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, the peer dep here won't be automatically updated when the version of the package gets bumped. That may be okay, just letting you know.

@iclanton
Copy link
Member Author

I intentionally made the peerdep version specifier broad.

@iclanton iclanton disabled auto-merge September 28, 2022 01:07
@iclanton iclanton merged commit 0cbcd77 into microsoft:main Sep 28, 2022
@iclanton iclanton deleted the load-themed-styles-peerdep branch September 28, 2022 01:07
This was referenced Nov 28, 2023
Open
Open
Open
Open
Open
This was referenced Mar 23, 2024
Open
Open
Open
Open
Open
This was referenced May 13, 2024
Open
Open
Open
Open
Open
This was referenced May 22, 2024
Open
Open
Open
This was referenced May 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D4N14L D4N14L D4N14L approved these changes

@octogonz octogonz Awaiting requested review from octogonz octogonz is a code owner

@apostolisms apostolisms Awaiting requested review from apostolisms apostolisms is a code owner

@patmill patmill Awaiting requested review from patmill patmill is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iclanton @D4N14L