[rush] Only check for overlapping output folders within operations that will be invoked as part of the same command. #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be invoked as part of the same command.
iclanton
requested review from
apostolisms,
D4N14L,
halfnibble,
octogonz and
sachinjoseph
as code owners
iclanton
changed the title
octogonz
reviewed
Jan 18, 2022
Co-authored-by: Pete Gonzalez <[email protected]>
octogonz
reviewed
Jan 18, 2022
octogonz
reviewed
Jan 18, 2022
octogonz
reviewed
Jan 18, 2022
iclanton
force-pushed
the
fix-overlapping-paths-check
branch
from
05b7edf to
60459eb
Compare
octogonz
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This issue was found when testing [email protected]. If a
rush-project.jsonhas matching lists of folders forbuildand_phase:buildoperations, validation will fail. This change checks for overlapping folders only among operations that will be invoked by a single command. For example, ifrush buildinvokes_phase:buildand_phase:test, and_phase:buildand_phase:linthave overlapping output folders, there is no error because_phase:buildand_phase:lintaren't invoked by the same command.How it was tested
Confirmed #3144 is fixed, and introduced an issue in a phased repo to confirm the expected behavior.