[rush] Refactor the task runner code to be more naturally adapted to phased builds. #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umb the log filename through from the command line parser.
iclanton
requested review from
apostolisms,
D4N14L,
halfnibble,
octogonz and
sachinjoseph
as code owners
iclanton
changed the title
octogonz
reviewed
Dec 21, 2021
octogonz
reviewed
Dec 21, 2021
iclanton
force-pushed
the
pre-phased-refactors
branch
from
0739837 to
5648e7b
Compare
iclanton
force-pushed
the
pre-phased-refactors
branch
from
5648e7b to
2780867
Compare
octogonz
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change renames a bunch of files and classes around the task runner to no longer mention the word "build" and refactors the task selector to be more easily adapted to specify multiple tasks per project.
This also replaces the "build" portion of log filenames with a normalized version of the name of the script being run.
Details
This change touches a large number of files, but most of the change is renames and minor refactors. A follow-up PR will introduce phased commands to the task scheduler.
Reference: Design Proposal: "phased" custom commands
How it was tested
Tested by building this repo and a large internal repo.