[rush] Rework execution engine #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
dmichon-msft
force-pushed
the
scheduler-rework
branch
2 times, most recently
from
7aef6f4 to
75d9666
Compare
D4N14L
approved these changes
Dec 2, 2021
dmichon-msft
force-pushed
the
scheduler-rework
branch
2 times, most recently
from
fdac3f6 to
a5fcac4
Compare
iclanton
reviewed
Jan 5, 2022
iclanton
reviewed
Jan 5, 2022
libraries/heft-config-file/src/test/__snapshots__/ConfigurationFile.test.ts.snap
Outdated
Show resolved
Hide resolved
dmichon-msft
force-pushed
the
scheduler-rework
branch
3 times, most recently
from
d4bf2f5 to
abe0709
Compare
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
iclanton
reviewed
Jan 8, 2022
dmichon-msft
force-pushed
the
scheduler-rework
branch
from
abe0709 to
6f80e43
Compare
2 tasks
dmichon-msft
force-pushed
the
scheduler-rework
branch
from
6f80e43 to
da85e80
Compare
dmichon-msft
commented
Jan 19, 2022
iclanton
reviewed
Jan 20, 2022
iclanton
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the task execution engine in Rush to interact with the task queue using the ECMAScript async iteration protocol.
Details
Creates a new
AsyncTaskQueuecomponent that implements the async iteration protocol (Symbol.asyncIterator)Updates the TaskSelector to be reusable within a watch mode process for multiple build passes, moving the pass-specific parameters to the
createTasks()method. Ensures that all dependency relationships between tasks are preserved, even if the across tasks that are excluded from a build.Adds a local vscode launch configuration to debug a unit test file in a Heft project.
Updates interaction with the build cache such that, if a dependency task is skipped for any reason, the task will not write to the build cache.
How it was tested
Various local build commands.
Verified that unsafe selection parameters (e.g.
-o rush-lib) work as expected.