[rush-lib] Fix a regression in the S3 cloud build cache provider #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliot-nelson
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
elliot-nelson
force-pushed
the
fix-s3-credentials
branch
from
ba1391f to
868f39a
Compare
iclanton
approved these changes
Apr 30, 2021
|
This has been published in Rush 5.45.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As reported in the zulipchat: a regression was introduced in #2614 that broke the signature generation for S3 requests (the header name signature delimiter was
,instead of;). Update the code and snapshots to correct.(As the PR template suggests...
Pushing additional commits with "small" fixes often invalidates testing.😢 )Details
N/A (this fix is for the S3 option of the experimental cloud build cache feature).
How it was tested