[rush] Initial implementation of Rush build cache feature. #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
force-pushed
the
ianc/rush-build-cache-az
branch
3 times, most recently
from
12836e8 to
3d9e7d9
Compare
iclanton
requested review from
D4N14L,
halfnibble,
octogonz,
patmill and
sachinjoseph
as code owners
iclanton
force-pushed
the
ianc/rush-build-cache-az
branch
2 times, most recently
from
eb09819 to
a5110c7
Compare
octogonz
reviewed
Dec 21, 2020
octogonz
reviewed
Dec 21, 2020
octogonz
reviewed
Dec 21, 2020
iclanton
force-pushed
the
ianc/rush-build-cache-az
branch
from
a5110c7 to
eb45744
Compare
octogonz
reviewed
Dec 21, 2020
octogonz
reviewed
Dec 21, 2020
apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Dec 21, 2020
iclanton
force-pushed
the
ianc/rush-build-cache-az
branch
from
eb45744 to
fb22804
Compare
Co-authored-by: Pete Gonzalez <[email protected]>
octogonz
reviewed
Dec 22, 2020
octogonz
reviewed
Dec 22, 2020
octogonz
reviewed
Dec 22, 2020
octogonz
reviewed
Dec 22, 2020
octogonz
reviewed
Dec 22, 2020
octogonz
reviewed
Dec 22, 2020
octogonz
reviewed
Dec 22, 2020
octogonz
approved these changes
Dec 22, 2020
|
Please update the PR description with test notes. Since this is an "experimental" feature, the main validation of interest would be a proof that this won't break any existing Rush features when the experiment is disabled. |
iclanton
force-pushed
the
ianc/rush-build-cache-az
branch
from
d9f0d92 to
fef1f51
Compare
iclanton
force-pushed
the
ianc/rush-build-cache-az
branch
from
c5619ef to
d03d963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this issue for design: #2393
This branch will build this repo with this feature: https://github.com/iclanton/rushstack/tree/ianc/build-cache-example
Test Notes
In a clone of this repo without the
buildCacheexperiment turned on:rush rebuild --to .repeatedly in the@rushstack/tree-patternfolder without issuerush build --to .repeatedly in the@rushstack/tree-patternfolder without issuerush rebuild --to .repeatedly in the@rushstack/heftfolder without issuerush build --to .repeatedly in the@rushstack/heftfolder without issue