[rush] Fix an issue where "rushx" did not pass additional parameters to the shell script #2096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1232
Consider this script:
package.json
Suppose that you invoke this command:
BEFORE this PR, the shell would execute:
rm -f lib && node ./build.js
AFTER this PR, the shell will execute:
rm -f lib && node ./build.js a b c --production
Ideally we want a different design, where
rushx
has full syntax validation and--help
for every parameter. But until that ideal is realized, this PR lets people pass subcommands to their shell scripts similar to how NPM and Yarn do.