[rush] Shell tab completion

apps/rush-lib/src/api/LastInstallFlag.ts

@@ -2,12 +2,14 @@
 // See LICENSE in the project root for license information.
 
 import * as path from 'path';
-import * as _ from 'lodash';
-import { FileSystem, JsonFile, JsonObject } from '@rushstack/node-core-library';
+
+import { FileSystem, JsonFile, JsonObject, Import } from '@rushstack/node-core-library';
 
 import { PackageManagerName } from './packageManager/PackageManager';
 import { RushConfiguration } from './RushConfiguration';
 
+const lodash: typeof import('lodash') = Import.lazy('lodash', require);
+
 export const LAST_INSTALL_FLAG_FILE_NAME: string = 'last-install.flag';
 
 /**
@@ -58,7 +60,7 @@ export class LastInstallFlag {
 
     const newState: JsonObject = this._state;
 
-    if (!_.isEqual(oldState, newState)) {
+    if (!lodash.isEqual(oldState, newState)) {
       if (checkValidAndReportStoreIssues) {
         const pkgManager: PackageManagerName = newState.packageManager;
         if (pkgManager === 'pnpm') {

apps/rush-lib/src/api/Rush.ts

@@ -10,6 +10,7 @@ import { RushConstants } from '../logic/RushConstants';
 import { RushXCommandLine } from '../cli/RushXCommandLine';
 import { CommandLineMigrationAdvisor } from '../cli/CommandLineMigrationAdvisor';
 import { NodeJsCompatibility } from '../logic/NodeJsCompatibility';
+import { Utilities } from '../utilities/Utilities';
 
 /**
  * Options to pass to the rush "launch" functions.
@@ -37,6 +38,8 @@ export interface ILaunchOptions {
  * @public
  */
 export class Rush {
+  private static _version: string | undefined = undefined;
+
   /**
    * This API is used by the `@microsoft/rush` front end to launch the "rush" command-line.
    * Third-party tools should not use this API.  Instead, they should execute the "rush" binary
@@ -53,7 +56,9 @@ export class Rush {
   public static launch(launcherVersion: string, arg: ILaunchOptions): void {
     const options: ILaunchOptions = Rush._normalizeLaunchOptions(arg);
 
-    Rush._printStartupBanner(options.isManaged);
+    if (!Utilities.shouldRestrictConsoleOutput()) {
+      Rush._printStartupBanner(options.isManaged);
+    }
 
     if (!CommandLineMigrationAdvisor.checkArgv(process.argv)) {
       // The migration advisor recognized an obsolete command-line
@@ -87,7 +92,11 @@ export class Rush {
    * This is the same as the Rush tool version for that release.
    */
   public static get version(): string {
-    return PackageJsonLookup.loadOwnPackageJson(__dirname).version;
+    if (!this._version) {
+      this._version = PackageJsonLookup.loadOwnPackageJson(__dirname).version;
+    }
+
+    return this._version!;
   }
 
   /**

apps/rush-lib/src/api/RushConfiguration.ts

@@ -716,7 +716,7 @@ export class RushConfiguration {
           tempProjectName
         );
         this._projects.push(project);
-        if (this._projectsByName.get(project.packageName)) {
+        if (this._projectsByName.has(project.packageName)) {
           throw new Error(
             `The project name "${project.packageName}" was specified more than once` +
               ` in the rush.json configuration file.`

apps/rush-lib/src/api/RushConfigurationProject.ts

@@ -123,7 +123,7 @@ export class RushConfigurationProject {
       );
     }
 
-    this._packageJsonEditor = PackageJsonEditor.load(packageJsonFilename);
+    this._packageJsonEditor = PackageJsonEditor.fromObject(this._packageJson, packageJsonFilename);
 
     this._tempProjectName = tempProjectName;
 

apps/rush-lib/src/api/VersionPolicy.ts

@@ -1,9 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-import { cloneDeep } from 'lodash';
 import * as semver from 'semver';
-import { IPackageJson } from '@rushstack/node-core-library';
+import { IPackageJson, Import } from '@rushstack/node-core-library';
 
 import {
   IVersionPolicyJson,
@@ -17,6 +16,8 @@ import { PackageJsonEditor } from './PackageJsonEditor';
 import { RushConfiguration } from './RushConfiguration';
 import { RushConfigurationProject } from './RushConfigurationProject';
 
+const lodash: typeof import('lodash') = Import.lazy('lodash', require);
+
 /**
  * Type of version bumps
  * @beta
@@ -320,7 +321,7 @@ export class LockStepVersionPolicy extends VersionPolicy {
   }
 
   private _updatePackageVersion(project: IPackageJson, newVersion: semver.SemVer): IPackageJson {
-    const updatedProject: IPackageJson = cloneDeep(project);
+    const updatedProject: IPackageJson = lodash.cloneDeep(project);
     updatedProject.version = newVersion.format();
     return updatedProject;
   }
@@ -379,7 +380,7 @@ export class IndividualVersionPolicy extends VersionPolicy {
     if (this.lockedMajor) {
       const version: semver.SemVer = new semver.SemVer(project.version);
       if (version.major < this.lockedMajor) {
-        const updatedProject: IPackageJson = cloneDeep(project);
+        const updatedProject: IPackageJson = lodash.cloneDeep(project);
         updatedProject.version = `${this._lockedMajor}.0.0`;
         return updatedProject;
       } else if (version.major > this.lockedMajor) {

apps/rush-lib/src/cli/RushCommandLineParser.ts

@@ -67,15 +67,16 @@ export class RushCommandLineParser extends CommandLineParser {
         ' and automates package publishing.  It can manage decoupled subsets of projects with different' +
         ' release and versioning strategies.  A full API is included to facilitate integration with other' +
         ' automation tools.  If you are looking for a proven turnkey solution for monorepo management,' +
-        ' Rush is for you.'
+        ' Rush is for you.',
+      enableTabCompletionAction: true
     });
 
     this._rushOptions = this._normalizeOptions(options || {});
 
     try {
       const rushJsonFilename: string | undefined = RushConfiguration.tryFindRushJsonLocation({
         startingFolder: this._rushOptions.cwd,
-        showVerbose: true
+        showVerbose: !Utilities.shouldRestrictConsoleOutput()
       });
       if (rushJsonFilename) {
         this.rushConfiguration = RushConfiguration.loadFromConfigurationFile(rushJsonFilename);

apps/rush-lib/src/cli/actions/AddAction.ts

@@ -3,15 +3,21 @@
 
 import * as os from 'os';
 import * as semver from 'semver';
-
+import { Import } from '@rushstack/node-core-library';
 import { CommandLineFlagParameter, CommandLineStringParameter } from '@rushstack/ts-command-line';
 
 import { RushConfigurationProject } from '../../api/RushConfigurationProject';
 import { BaseRushAction } from './BaseRushAction';
 import { RushCommandLineParser } from '../RushCommandLineParser';
-import { PackageJsonUpdater, SemVerStyle } from '../../logic/PackageJsonUpdater';
 import { DependencySpecifier } from '../../logic/DependencySpecifier';
 
+// TODO: Convert this to "import type" after we upgrade to TypeScript 3.8
+import * as PackageJsonUpdaterTypes from '../../logic/PackageJsonUpdater';
+const packageJsonUpdaterModule: typeof PackageJsonUpdaterTypes = Import.lazy(
+  '../../logic/PackageJsonUpdater',
+  require
+);
+
 export class AddAction extends BaseRushAction {
   private _allFlag: CommandLineFlagParameter;
   private _exactFlag: CommandLineFlagParameter;
@@ -87,7 +93,7 @@ export class AddAction extends BaseRushAction {
     });
   }
 
-  public async run(): Promise<void> {
+  public async runAsync(): Promise<void> {
     let projects: RushConfigurationProject[];
     if (this._allFlag.value) {
       projects = this.rushConfiguration.projects;
@@ -136,9 +142,12 @@ export class AddAction extends BaseRushAction {
       }
     }
 
-    const updater: PackageJsonUpdater = new PackageJsonUpdater(this.rushConfiguration, this.rushGlobalFolder);
+    const updater: PackageJsonUpdaterTypes.PackageJsonUpdater = new packageJsonUpdaterModule.PackageJsonUpdater(
+      this.rushConfiguration,
+      this.rushGlobalFolder
+    );
 
-    let rangeStyle: SemVerStyle;
+    let rangeStyle: PackageJsonUpdaterTypes.SemVerStyle;
     if (version && version !== 'latest') {
       if (this._exactFlag.value || this._caretFlag.value) {
         throw new Error(
@@ -147,13 +156,13 @@ export class AddAction extends BaseRushAction {
         );
       }
 
-      rangeStyle = SemVerStyle.Passthrough;
+      rangeStyle = PackageJsonUpdaterTypes.SemVerStyle.Passthrough;
     } else {
       rangeStyle = this._caretFlag.value
-        ? SemVerStyle.Caret
+        ? PackageJsonUpdaterTypes.SemVerStyle.Caret
         : this._exactFlag.value
-        ? SemVerStyle.Exact
-        : SemVerStyle.Tilde;
+        ? PackageJsonUpdaterTypes.SemVerStyle.Exact
+        : PackageJsonUpdaterTypes.SemVerStyle.Tilde;
     }
 
     await updater.doRushAdd({

apps/rush-lib/src/cli/actions/BaseInstallAction.ts

@@ -4,6 +4,7 @@
 import * as colors from 'colors';
 import * as os from 'os';
 
+import { Import } from '@rushstack/node-core-library';
 import {
   CommandLineFlagParameter,
   CommandLineIntegerParameter,
@@ -13,7 +14,6 @@ import {
 import { BaseRushAction } from './BaseRushAction';
 import { Event } from '../../api/EventHooks';
 import { BaseInstallManager, IInstallManagerOptions } from '../../logic/base/BaseInstallManager';
-import { InstallManagerFactory } from '../../logic/InstallManagerFactory';
 import { PurgeManager } from '../../logic/PurgeManager';
 import { SetupChecks } from '../../logic/SetupChecks';
 import { StandardScriptUpdater } from '../../logic/StandardScriptUpdater';
@@ -22,6 +22,11 @@ import { VersionMismatchFinder } from '../../logic/versionMismatch/VersionMismat
 import { Variants } from '../../api/Variants';
 import { RushConstants } from '../../logic/RushConstants';
 
+const installManagerFactoryModule: typeof import('../../logic/InstallManagerFactory') = Import.lazy(
+  '../../logic/InstallManagerFactory',
+  require
+);
+
 /**
  * This is the common base class for InstallAction and UpdateAction.
  */
@@ -77,7 +82,7 @@ export abstract class BaseInstallAction extends BaseRushAction {
 
   protected abstract buildInstallOptions(): IInstallManagerOptions;
 
-  protected run(): Promise<void> {
+  protected runAsync(): Promise<void> {
     VersionMismatchFinder.ensureConsistentVersions(this.rushConfiguration, {
       variant: this._variant.value
     });
@@ -119,7 +124,7 @@ export abstract class BaseInstallAction extends BaseRushAction {
 
     const installManagerOptions: IInstallManagerOptions = this.buildInstallOptions();
 
-    const installManager: BaseInstallManager = InstallManagerFactory.getInstallManager(
+    const installManager: BaseInstallManager = installManagerFactoryModule.InstallManagerFactory.getInstallManager(
       this.rushConfiguration,
       this.rushGlobalFolder,
       purgeManager,

apps/rush-lib/src/cli/actions/BaseRushAction.ts

@@ -79,15 +79,17 @@ export abstract class BaseConfiglessRushAction extends CommandLineAction {
       }
     }
 
-    console.log(`Starting "rush ${this.actionName}"${os.EOL}`);
-    return this.run();
+    if (!Utilities.shouldRestrictConsoleOutput()) {
+      console.log(`Starting "rush ${this.actionName}"${os.EOL}`);
+    }
+    return this.runAsync();
   }
 
   /**
    * All Rush actions need to implement this method. This method runs after
    * environment has been set up by the base class.
    */
-  protected abstract run(): Promise<void>;
+  protected abstract runAsync(): Promise<void>;
 
   private _ensureEnvironment(): void {
     if (this.rushConfiguration) {