Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Pass --frozen-lockfile to rush install #1850

Merged
merged 9 commits into from
May 13, 2020

Conversation

sachinjoseph
Copy link
Member

@sachinjoseph sachinjoseph commented Apr 29, 2020

Also: Fixes #1300 (in a way😃). @octogonz FYI.

Disabled by default - to enable set the flag usePnpmFrozenLockfileForRushInstall in experiments.json.

@sachinjoseph sachinjoseph changed the title Pass --frozen-lockfile to rush install [rush] Pass --frozen-lockfile to rush install Apr 30, 2020
Copy link
Contributor

@dmichon-msft dmichon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The experiment allows us to trade off more shrinkwrap changes for determinism in the install process, and should also result in faster installs.

@sachinjoseph
Copy link
Member Author

@octogonz Do you want to take a look?

@iclanton iclanton merged commit 510dfd9 into master May 13, 2020
@iclanton iclanton deleted the sachinjoseph/pnpmFrozenLockfile branch May 13, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[rush] Provide an option to make the committed shrinkwrap capture the exact installation plan
4 participants