-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Pass --frozen-lockfile to rush install #1850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into sachinjoseph/pnpmFrozenLockfile
…hrinkwrap back to common/config/rush if allowShrinkwrapUpdates (true for "rush update", false for "rush install") is true.
sachinjoseph
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton and
octogonz
as code owners
April 29, 2020 06:03
sachinjoseph
changed the title
Pass --frozen-lockfile to rush install
[rush] Pass --frozen-lockfile to rush install
Apr 30, 2020
dmichon-msft
approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The experiment allows us to trade off more shrinkwrap changes for determinism in the install process, and should also result in faster installs.
apostolisms
approved these changes
May 6, 2020
iclanton
approved these changes
May 6, 2020
@octogonz Do you want to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: Fixes #1300 (in a way😃). @octogonz FYI.
Disabled by default - to enable set the flag
usePnpmFrozenLockfileForRushInstall
inexperiments.json
.