Bump tslint-microsoft-contrib to ~6.2.0 to include react-this-binding-issue rule fix #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinTCoughlin
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton,
octogonz,
patmill and
sachinjoseph
as code owners
octogonz
reviewed
Mar 28, 2020
common/changes/@rushstack/ts-command-line/keco-tslint-microsoft-contrib_2020-03-28-03-28.json
Outdated
Show resolved
Hide resolved
|
LGTM but the CI build failed |
Thanks, let me try this again. |
KevinTCoughlin
force-pushed
the
keco/tslint-microsoft-contrib
branch
from
5cd7bf5 to
4cffb03
Compare
|
I'll have to investigate why snapshots are churning. It happens across enlistments. I don't see a jest related dependency update in the lockfile. |
iclanton
force-pushed
the
keco/tslint-microsoft-contrib
branch
2 times, most recently
from
df7ef65 to
eca0528
Compare
iclanton
force-pushed
the
keco/tslint-microsoft-contrib
branch
from
eca0528 to
0b27585
Compare
iclanton
approved these changes
Apr 3, 2020
|
Thanks @iclanton 👏. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
tslintis deprecated, some downstream repos have not yet been migrated toeslint. We'd like to bump[email protected]namely to include the following rule fix: microsoft/tslint-microsoft-contrib#813. Currently, I'm pinning the version usingpnpmfile.jsin the downstream repo.cc: @dennisjsyi