Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-extractor] ApiItem.name is now quoted when it contains invalid identifier characters #1410

Merged
merged 10 commits into from
Jul 23, 2019

Conversation

octogonz
Copy link
Collaborator

@octogonz octogonz commented Jul 22, 2019

To avoid conflicts with an ECMAScript symbol expression, ApiItem.name is now quoted when it contains invalid identifier characters,

This is a prerequisite for PR #1406

I'm doing it as a separate PR to make the review easier.

@rbuckton FYI

apps/api-documenter/src/utils/Utilities.ts Outdated Show resolved Hide resolved
apps/api-extractor/src/analyzer/AstSymbolTable.ts Outdated Show resolved Hide resolved
apps/api-extractor/src/analyzer/AstSymbolTable.ts Outdated Show resolved Hide resolved
@octogonz octogonz merged commit ae327a5 into master Jul 23, 2019
@octogonz octogonz deleted the octogonz/ae-name-escaping branch July 23, 2019 00:20
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request Jul 23, 2019
We had to rename it from `(construcotr).md` to `_constructor_.md`.
Now it's fixed by microsoft/rushstack#1410.
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request Jul 23, 2019
We had to rename it from `(construcotr).md` to `_constructor_.md`.
Now it's fixed by microsoft/rushstack#1410.
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request Jul 23, 2019
We had to rename it from `(construcotr).md` to `_constructor_.md`.
Now it's fixed by microsoft/rushstack#1410.
rikhoffbauer pushed a commit to rikhoffbauer/microsoft__api-documenter that referenced this pull request Mar 23, 2020
…aping

[api-extractor] ApiItem.name is now quoted when it contains invalid identifier characters
javier-garcia-meteologica pushed a commit to javier-garcia-meteologica/rushstack that referenced this pull request Jun 26, 2020
…aping

[api-extractor] ApiItem.name is now quoted when it contains invalid identifier characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants