-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-extractor] ApiItem.name is now quoted when it contains invalid identifier characters #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octogonz
requested review from
apostolisms,
halfnibble,
iclanton,
Lincoded and
sachinjoseph
as code owners
July 22, 2019 19:21
iclanton
approved these changes
Jul 22, 2019
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
Jul 23, 2019
We had to rename it from `(construcotr).md` to `_constructor_.md`. Now it's fixed by microsoft/rushstack#1410.
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
Jul 23, 2019
We had to rename it from `(construcotr).md` to `_constructor_.md`. Now it's fixed by microsoft/rushstack#1410.
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
Jul 23, 2019
We had to rename it from `(construcotr).md` to `_constructor_.md`. Now it's fixed by microsoft/rushstack#1410.
rikhoffbauer
pushed a commit
to rikhoffbauer/microsoft__api-documenter
that referenced
this pull request
Mar 23, 2020
…aping [api-extractor] ApiItem.name is now quoted when it contains invalid identifier characters
javier-garcia-meteologica
pushed a commit
to javier-garcia-meteologica/rushstack
that referenced
this pull request
Jun 26, 2020
…aping [api-extractor] ApiItem.name is now quoted when it contains invalid identifier characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid conflicts with an ECMAScript symbol expression, ApiItem.name is now quoted when it contains invalid identifier characters,
This is a prerequisite for PR #1406
I'm doing it as a separate PR to make the review easier.
@rbuckton FYI