Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-extractor] Namespace export created by import/export * does not remove exports that have been trimmed #3639

Closed
jakebailey opened this issue Sep 23, 2022 · 3 comments
Closed

[api-extractor] Namespace export created by import/export * does not remove exports that have been trimmed #3639

jakebailey opened this issue Sep 23, 2022 · 3 comments

Comments

@jakebailey
Copy link
Member

Summary

I am recreating TypeScript's namespaces using api-extractor and barrel files with exports; when I run api-extractor, things marked @internal are correctly removed, but are not removed from the recreated namespaces.

Repro steps

Expected result: When everything but the pubic API is removed, the namespace exports should not contain those trimmed items.

Actual result: The namespace exports still contain the trimmed items.

Repro: https://github.com/jakebailey/api-extractor-export-star-internal-namespace

Details

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/api-extractor version? 7.31.2
Operating system? Windows
API Extractor scenario? rollups (.d.ts)
Would you consider contributing a PR? Yes
TypeScript compiler version? 4.8.3
Node.js version (node -v)? 14.19.2
@jakebailey jakebailey mentioned this issue Sep 23, 2022
Closed
@CraigMacomber
Copy link

I also hit this issue. It still happens in api-extractor 7.38.3 and TypeScript 5.1.6. Our impacted package is https://github.com/microsoft/FluidFramework/tree/main/experimental/dds/tree2 .

@CraigMacomber
Copy link

I think this issue is a duplicate of #2791 which has a fix in #2793 . Would be excellent if we could get that merged.

@CraigMacomber CraigMacomber mentioned this issue Dec 1, 2023
Merged
CraigMacomber added a commit to microsoft/FluidFramework that referenced this issue Dec 4, 2023
@CraigMacomber
tree2: Cleanup internal namespaces (#18603)
3692310 
## Description

Cleanup some of the internal types which were exported in "internal"
namespaces as implementation details of typing stuff.

These namespaces, when they contain alpha items break beta releases due
to an API-Extractor issue:
microsoft/rushstack#3639

## Breaking Changes

Several "internal" types were moved/renamed and some `@alpha` flex tree
types were renamed (mainly ones from the SchemaAware namespaces which
was removed).
@octogonz
Copy link
Collaborator

octogonz commented Dec 5, 2023

I think this issue is a duplicate of #2791 which has a fix in #2793 . Would be excellent if we could get that merged.

PR #2793 has been merged 👍

@octogonz octogonz closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@octogonz @jakebailey @CraigMacomber