Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[heft] Update node-sass to support node 15. #2510

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

halfnibble
Copy link
Contributor

Summary

Update node-sass to support Node 15.

Details

Fixes #2490
Note: Loses heft sass support for Node versions 8, 11, and 13.

How it was tested

Tested with build-tests/heft-sass-test

Note:
Loses heft sass support for Node versions 8, 11, and 13.
@chengcyber
Copy link
Contributor

Kind of curious about whether it is possible to use sass (Dart Sass) package instead of node-sass. Since node-sass has been deprecated.

@halfnibble
Copy link
Contributor Author

Kind of curious about whether it is possible to use sass (Dart Sass) package instead of node-sass. Since node-sass has been deprecated.

Probably. Last time I tried dart sass it was about 3x slower than libsass. I've actually mulled the idea of forking node-sass and creating my own open source library. There are some features I want in Sass that the maintainers don't seem too keen on. But alas, I doubt I have the time.

@dmichon-msft
Copy link
Contributor

There's a recommendation that Dart Sass is faster than node-sass if you get the version that runs the Dart VM, but that one doesn't ship as an npm package.

@xc2
Copy link

xc2 commented Mar 2, 2021

How about using sass@npm instead of node-sass@npm in rushstack by default, and providing options for user to specific render function or sass package.

@halfnibble
Copy link
Contributor Author

How about using sass@npm instead of node-sass@npm in rushstack by default, and providing options for user to specific render function or sass package.

We are going to refactor this Heft plugin and make the entire sass plugin both optional (many node projects don't need Sass) and configurable. I'll create a separate issue to track that endeavor. As a quick fix, however, I will get this version bump in as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[heft] Update node-sass dependency to 5.0.0 in order to fix builds with Node 15
5 participants