Merge pull request #2510 from microsoft/user/halfnibble/update-node-sass

[heft] Update node-sass to support node 15.
microsoft · Mar 11, 2021 · 5e10df7 · 5e10df7
2 parents 61efcc5 + 56a9d74
commit 5e10df7
Show file tree

Hide file tree

Showing 7 changed files with 143 additions and 43 deletions.
diff --git a/apps/heft/package.json b/apps/heft/package.json
@@ -49,7 +49,7 @@
     "glob": "~7.0.5",
     "glob-escape": "~0.0.2",
     "jest-snapshot": "~25.4.0",
-    "node-sass": "4.14.1",
+    "node-sass": "5.0.0",
     "postcss": "7.0.32",
     "postcss-modules": "~1.5.0",
     "prettier": "~2.1.1",

diff --git a/build-tests/heft-sass-test/package.json b/build-tests/heft-sass-test/package.json
@@ -5,7 +5,7 @@
   "private": true,
   "scripts": {
     "build": "heft test --clean",
-    "start": "heft start"
+    "start": "heft start --clean"
   },
   "devDependencies": {
     "@rushstack/eslint-config": "workspace:*",
@@ -18,12 +18,12 @@
     "css-loader": "~4.2.1",
     "eslint": "~7.12.1",
     "html-webpack-plugin": "~4.5.0",
-    "node-sass": "4.14.1",
+    "node-sass": "5.0.0",
     "postcss": "7.0.32",
     "postcss-loader": "~4.0.1",
     "react-dom": "~16.13.1",
     "react": "~16.13.1",
-    "sass-loader": "~7.3.1",
+    "sass-loader": "~10.1.1",
     "style-loader": "~1.2.1",
     "typescript": "~3.9.7",
     "webpack": "~4.44.2"

diff --git a/...es/@microsoft/gulp-core-build-sass/user-halfnibble-update-node-sass_2021-02-25-21-42.json b/...es/@microsoft/gulp-core-build-sass/user-halfnibble-update-node-sass_2021-02-25-21-42.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/gulp-core-build-sass",
+      "comment": "Update node-sass to support Node 15.",
+      "type": "minor"
+    }
+  ],
+  "packageName": "@microsoft/gulp-core-build-sass",
+  "email": "[email protected]"
+}
diff --git a/common/changes/@rushstack/heft/user-halfnibble-update-node-sass_2021-02-25-21-42.json b/common/changes/@rushstack/heft/user-halfnibble-update-node-sass_2021-02-25-21-42.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft",
+      "comment": "Update node-sass to support Node 15.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/heft",
+  "email": "[email protected]"
+}