Skip to content

Commit

Permalink
Merge pull request #3937 from iclanton/move-node-dependency
Browse files Browse the repository at this point in the history
Move the @types/node dependency to an optional peerDependency.
  • Loading branch information
iclanton authored Jan 30, 2023
2 parents 3e8bdce + 60a376a commit c7fd1c7
Show file tree
Hide file tree
Showing 21 changed files with 203 additions and 37 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/module-minifier"
}
],
"packageName": "@rushstack/module-minifier",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/node-core-library"
}
],
"packageName": "@rushstack/node-core-library",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/terminal"
}
],
"packageName": "@rushstack/terminal",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/typings-generator"
}
],
"packageName": "@rushstack/typings-generator",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/webpack-preserve-dynamic-require-plugin"
}
],
"packageName": "@rushstack/webpack-preserve-dynamic-require-plugin",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/webpack4-localization-plugin"
}
],
"packageName": "@rushstack/webpack4-localization-plugin",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/webpack4-module-minifier-plugin"
}
],
"packageName": "@rushstack/webpack4-module-minifier-plugin",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/webpack5-localization-plugin"
}
],
"packageName": "@rushstack/webpack5-localization-plugin",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/webpack5-module-minifier-plugin"
}
],
"packageName": "@rushstack/webpack5-module-minifier-plugin",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Move the @types/node dependency to an optional peerDependency.",
"type": "minor",
"packageName": "@rushstack/worker-pool"
}
],
"packageName": "@rushstack/worker-pool",
"email": "[email protected]"
}
19 changes: 9 additions & 10 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions libraries/module-minifier/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"_phase:test": "heft test --no-build"
},
"dependencies": {
"@types/node": "12.20.24",
"@rushstack/worker-pool": "workspace:*",
"serialize-javascript": "6.0.0",
"source-map": "~0.7.3",
Expand All @@ -27,6 +26,15 @@
"@rushstack/heft": "workspace:*",
"@rushstack/heft-node-rig": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/serialize-javascript": "5.0.2"
"@types/serialize-javascript": "5.0.2",
"@types/node": "12.20.24"
},
"peerDependencies": {
"@types/node": "^12.20.24"
},
"peerDependenciesMeta": {
"@types/node": {
"optional": true
}
}
}
12 changes: 10 additions & 2 deletions libraries/node-core-library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"_phase:test": "heft test --no-build"
},
"dependencies": {
"@types/node": "12.20.24",
"colors": "~1.2.1",
"fs-extra": "~7.0.1",
"import-lazy": "~4.0.0",
Expand All @@ -33,6 +32,15 @@
"@types/heft-jest": "1.0.1",
"@types/jju": "1.4.1",
"@types/resolve": "1.20.2",
"@types/semver": "7.3.5"
"@types/semver": "7.3.5",
"@types/node": "12.20.24"
},
"peerDependencies": {
"@types/node": "^12.20.24"
},
"peerDependenciesMeta": {
"@types/node": {
"optional": true
}
}
}
12 changes: 10 additions & 2 deletions libraries/terminal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
},
"dependencies": {
"@rushstack/node-core-library": "workspace:*",
"@types/node": "12.20.24",
"wordwrap": "~1.0.0"
},
"devDependencies": {
Expand All @@ -26,6 +25,15 @@
"@rushstack/heft-node-rig": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/wordwrap": "~1.0.0",
"colors": "~1.2.1"
"colors": "~1.2.1",
"@types/node": "12.20.24"
},
"peerDependencies": {
"@types/node": "^12.20.24"
},
"peerDependenciesMeta": {
"@types/node": {
"optional": true
}
}
}
12 changes: 10 additions & 2 deletions libraries/typings-generator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,22 @@
},
"dependencies": {
"@rushstack/node-core-library": "workspace:*",
"@types/node": "12.20.24",
"chokidar": "~3.4.0",
"glob": "~7.0.5"
},
"devDependencies": {
"@rushstack/eslint-config": "workspace:*",
"@rushstack/heft": "workspace:*",
"@rushstack/heft-node-rig": "workspace:*",
"@types/glob": "7.1.1"
"@types/glob": "7.1.1",
"@types/node": "12.20.24"
},
"peerDependencies": {
"@types/node": "^12.20.24"
},
"peerDependenciesMeta": {
"@types/node": {
"optional": true
}
}
}
14 changes: 10 additions & 4 deletions libraries/worker-pool/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,19 @@
"_phase:build": "heft build --clean",
"_phase:test": "heft test --no-build"
},
"dependencies": {
"@types/node": "12.20.24"
},
"devDependencies": {
"@rushstack/eslint-config": "workspace:*",
"@rushstack/heft": "workspace:*",
"@rushstack/heft-node-rig": "workspace:*",
"@types/heft-jest": "1.0.1"
"@types/heft-jest": "1.0.1",
"@types/node": "12.20.24"
},
"peerDependencies": {
"@types/node": "^12.20.24"
},
"peerDependenciesMeta": {
"@types/node": {
"optional": true
}
}
}
Loading

0 comments on commit c7fd1c7

Please sign in to comment.