Merge pull request #4577 from kamontat/patch-1

[heft] Fix MetricsCollector has not been initialized with setStartTime() yet when run clean
microsoft · Mar 14, 2024 · ba823b5 · ba823b5
2 parents f40468e + 02742fe
commit ba823b5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/apps/heft/src/cli/actions/CleanAction.ts b/apps/heft/src/cli/actions/CleanAction.ts
@@ -80,6 +80,8 @@ export class CleanAction extends CommandLineAction implements IHeftAction {
     const { heftConfiguration } = this._internalHeftSession;
     const abortSignal: AbortSignal = ensureCliAbortSignal(this._terminal);
 
+    // Record this as the start of task execution.
+    this._metricsCollector.setStartTime();
     initializeHeft(heftConfiguration, this._terminal, this._verboseFlag.value);
     await runWithLoggingAsync(
       this._cleanFilesAsync.bind(this),

diff --git a/common/changes/@rushstack/heft/patch-1_2024-03-14-12-44.json b/common/changes/@rushstack/heft/patch-1_2024-03-14-12-44.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft",
+      "comment": "Fix internal error when run 'heft clean'",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/heft"
+}