Only update snapshots in non-production mode.

microsoft · Jul 15, 2020 · 7df2917 · 7df2917
1 parent 64ee507
commit 7df2917
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/apps/heft/src/cli/actions/TestAction.ts b/apps/heft/src/cli/actions/TestAction.ts
@@ -20,6 +20,7 @@ export class TestHooks extends ActionHooksBase<ITestActionProperties> {
  */
 export interface ITestActionProperties {
   watchMode: boolean;
+  productionFlag: boolean;
 }
 
 /**
@@ -60,7 +61,8 @@ export class TestAction extends BuildAction {
     const testActionContext: ITestActionContext = {
       hooks: new TestHooks(),
       properties: {
-        watchMode: buildActionContext.properties.watchMode
+        watchMode: buildActionContext.properties.watchMode,
+        productionFlag: buildActionContext.properties.productionFlag
       }
     };
     const shouldBuild: boolean = !this._noBuildFlag.value;

diff --git a/apps/heft/src/plugins/JestPlugin/JestPlugin.ts b/apps/heft/src/plugins/JestPlugin/JestPlugin.ts
@@ -21,13 +21,21 @@ export class JestPlugin implements IHeftPlugin {
     if (FileSystem.exists(path.join(heftConfiguration.buildFolder, JEST_CONFIGURATION_LOCATION))) {
       heftSession.hooks.test.tap(PLUGIN_NAME, (test: ITestActionContext) => {
         test.hooks.run.tapPromise(PLUGIN_NAME, async () => {
-          await this._runJestAsync(heftConfiguration, test.properties.watchMode);
+          await this._runJestAsync(
+            heftConfiguration,
+            test.properties.watchMode,
+            test.properties.productionFlag
+          );
         });
       });
     }
   }
 
-  private async _runJestAsync(heftConfiguration: HeftConfiguration, watchMode: boolean): Promise<void> {
+  private async _runJestAsync(
+    heftConfiguration: HeftConfiguration,
+    watchMode: boolean,
+    production: boolean
+  ): Promise<void> {
     const buildFolder: string = heftConfiguration.buildFolder;
     const reporterOptions: IHeftJestReporterOptions = { heftConfiguration };
     const { results: jestResults } = await runCLI(
@@ -36,6 +44,7 @@ export class JestPlugin implements IHeftPlugin {
         config: JEST_CONFIGURATION_LOCATION,
         reporters: [[path.resolve(__dirname, 'HeftJestReporter.js'), reporterOptions]],
         cacheDirectory: path.join(heftConfiguration.buildCacheFolder, 'jest-cache'),
+        updateSnapshot: !production,
 
         listTests: false,
         rootDir: buildFolder,

diff --git a/common/reviews/api/heft.api.md b/common/reviews/api/heft.api.md
@@ -292,6 +292,8 @@ export interface ITestActionContext extends IActionContext<TestHooks, ITestActio
 
 // @public (undocumented)
 export interface ITestActionProperties {
+    // (undocumented)
+    productionFlag: boolean;
     // (undocumented)
     watchMode: boolean;
 }