Skip to content

Commit

Permalink
docs: Update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Josmithr authored Feb 21, 2024
1 parent 05719ca commit 5430b35
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion apps/api-extractor/src/generators/DtsRollupGenerator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ export class DtsRollupGenerator {
// Emit the imports
for (const entity of collector.entities) {
if (entity.astEntity instanceof AstImport) {
// BUG MITIGATION: don't trim imports based on their release tags
// Note: it isn't valid to trim imports based on their release tags.
// E.g. class Foo (`@public`) extends interface Bar (`@beta`) from some external library.
// API-Extractor cannot trim `import { Bar } from "externa-library"` when generating its public rollup,
// or the export of `Foo` would include a broken reference to `Bar`.
const astImport: AstImport = entity.astEntity;
DtsEmitHelpers.emitImport(writer, entity, astImport);
}
Expand Down

0 comments on commit 5430b35

Please sign in to comment.