Skip to content

Commit

Permalink
chore: documentation and PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
william2958 committed Dec 4, 2023
1 parent 2fbdc7d commit 2d53710
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion common/reviews/api/rush-lib.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -1124,7 +1124,7 @@ export class RushConfiguration {
readonly _rushPluginsConfiguration: RushPluginsConfiguration;
readonly shrinkwrapFilename: string;
get shrinkwrapFilePhrase(): string;
// Warning: (ae-incompatible-release-tags) The symbol "subspaceConfiguration" is marked as @public, but its signature references "SubspaceConfiguration" which is marked as @beta
// @beta
readonly subspaceConfiguration?: SubspaceConfiguration;
get subspaceNames(): string[];
readonly subspaceShrinkwrapFilenames: (subspaceName: string) => string;
Expand Down
1 change: 1 addition & 0 deletions libraries/rush-lib/src/api/RushConfiguration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ export class RushConfiguration {

/**
* The object that specifies subspace configurations if they are provided in the rush workspace.
* @beta
*/
public readonly subspaceConfiguration?: SubspaceConfiguration;

Expand Down
8 changes: 6 additions & 2 deletions libraries/rush-lib/src/api/SubspaceConfiguration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,17 @@ export interface ISubspaceConfig {
}

/**
* (DEPRECATED)
*
* This represents the JSON data structure for the "subspace.json" configuration file.
* See subspace.schema.json for documentation.
* See subspace.schema.json for documentation. Includes the depreciated splitWorkspaceCompatibility property
* used to help migrate workspaces from a split-workspace state.
*
*/
export interface ISubspaceConfigurationJson {
$schema: string;
enabled: boolean;
depreciatedTTSupport?: boolean;
splitWorkspaceCompatibility?: boolean;
availableSubspaces: ISubspaceConfig;
}

Expand Down
4 changes: 2 additions & 2 deletions libraries/rush-lib/src/schemas/subspace.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"description": "If true, rush will use the subspaces configuration",
"type": "boolean"
},
"depreciated_tt_support": {
"description": "A depreciated option that allows individual subspaces to be configured at the package level if that package is the only project in the subspace.",
"splitWorkspaceCompatibility": {
"description": "(DEPRECATED) A depreciated option that allows individual subspaces to be configured at the package level if that package is the only project in the subspace. Used to help migrate from a split workspace state.",
"type": "boolean"
},
"availableSubspaces": {
Expand Down

0 comments on commit 2d53710

Please sign in to comment.