Merge pull request #4401 from sanjaiyan-dev/sanjaiyan-async-concurrent

[rush-lib] Enhancing Performance with Concurrent Execution using `Promise.all` ✈
microsoft · Oct 27, 2023 · 1f101e6 · 1f101e6
2 parents 7015675 + aef5a50
commit 1f101e6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/common/changes/@microsoft/rush/sanjaiyan-async-concurrent_2023-10-20-07-32.json b/common/changes/@microsoft/rush/sanjaiyan-async-concurrent_2023-10-20-07-32.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "performance improvements by running asynchronous code concurrently using Promise.all",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}
diff --git a/libraries/rush-lib/scripts/copyEmptyModules.js b/libraries/rush-lib/scripts/copyEmptyModules.js
@@ -1,6 +1,6 @@
 'use strict';
 
-const { FileSystem } = require('@rushstack/node-core-library');
+const { FileSystem, Async } = require('@rushstack/node-core-library');
 
 const JS_FILE_EXTENSION = '.js';
 const DTS_FILE_EXTENSION = '.d.ts';
@@ -50,7 +50,7 @@ module.exports = {
       const folderItems = await FileSystem.readFolderItemsAsync(
         relativeFolderPath ? `${jsInFolderPath}/${relativeFolderPath}` : jsInFolderPath
       );
-      for (const folderItem of folderItems) {
+      await Async.forEachAsync(folderItems, async (folderItem) => {
         const itemName = folderItem.name;
         const relativeItemPath = relativeFolderPath ? `${relativeFolderPath}/${itemName}` : itemName;
 
@@ -76,7 +76,7 @@ module.exports = {
             await FileSystem.writeFileAsync(outDtsPath, buffer, { ensureFolderExists: true });
           }
         }
-      }
+      });
     }
 
     await searchAsync(undefined);