Merge pull request #4389 from theJiawen/jiawen/fix-color

[rush-lib] Remove "--color=always" option when invoking pnpm install
microsoft · Oct 10, 2023 · 118feea · 118feea
2 parents e8db1da + b5b0a47
commit 118feea
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/common/changes/@microsoft/rush/jiawen-fix-color_2023-10-09-21-33.json b/common/changes/@microsoft/rush/jiawen-fix-color_2023-10-09-21-33.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Improve color logic when invoking package managers' install ",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}
diff --git a/libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts b/libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts
@@ -292,6 +292,9 @@ export class WorkspaceInstallManager extends BaseInstallManager {
       this.rushConfiguration,
       this.options
     );
+    if (colors.enabled) {
+      packageManagerEnv.FORCE_COLOR = '1';
+    }
 
     const commonNodeModulesFolder: string = path.join(
       this.rushConfiguration.commonTempFolder,
@@ -318,7 +321,7 @@ export class WorkspaceInstallManager extends BaseInstallManager {
       // Run "npm install" in the common folder
       // To ensure that the output is always colored, set the option "--color=always", even when it's piped.
       // Without this argument, certain text that should be colored (such as red) will appear white.
-      const installArgs: string[] = ['install', '--color=always'];
+      const installArgs: string[] = ['install'];
       this.pushConfigurationArgs(installArgs, options);
 
       // eslint-disable-next-line no-console