[rush-lib] Fix edge cases where Rush does not update the lockfile (#4839

)

* fix: edge cases where Rush does not update the lockfile

* rush change

* Rush change.

---------

Co-authored-by: qun <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>

common/changes/@microsoft/rush/fix-edge-case_2024-07-18-06-38.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where Rush does not detect an outdated lockfile if the `dependenciesMeta` `package.json` field is edited.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}

libraries/rush-lib/src/logic/pnpm/PnpmShrinkwrapFile.ts

@@ -872,7 +872,7 @@ export class PnpmShrinkwrapFile extends BaseShrinkwrapFile {
 
     // Use a new PackageJsonEditor since it will classify each dependency type, making tracking the
     // found versions much simpler.
-    const { dependencyList, devDependencyList } = PackageJsonEditor.fromObject(
+    const { dependencyList, devDependencyList, dependencyMetaList } = PackageJsonEditor.fromObject(
       this._pnpmfileConfiguration.transform(transformedPackageJson),
       project.packageJsonEditor.filePath
     );
@@ -960,6 +960,7 @@ export class PnpmShrinkwrapFile extends BaseShrinkwrapFile {
       );
       const importerDependencies: Set<string> = new Set(Object.keys(importer.dependencies ?? {}));
       const importerDevDependencies: Set<string> = new Set(Object.keys(importer.devDependencies ?? {}));
+      const importerDependenciesMeta: Set<string> = new Set(Object.keys(importer.dependenciesMeta ?? {}));
 
       for (const { dependencyType, name, version } of allDependencies) {
         let isOptional: boolean = false;
@@ -1019,11 +1020,18 @@ export class PnpmShrinkwrapFile extends BaseShrinkwrapFile {
         }
       }
 
+      for (const { name, injected } of dependencyMetaList) {
+        if (importer.dependenciesMeta?.[name]?.injected === injected) {
+          importerDependenciesMeta.delete(name);
+        }
+      }
+
       // Finally, validate that all values in the importer are also present in the dependency list.
       if (
         importerOptionalDependencies.size > 0 ||
         importerDependencies.size > 0 ||
-        importerDevDependencies.size > 0
+        importerDevDependencies.size > 0 ||
+        importerDependenciesMeta.size > 0
       ) {
         return true;
       }