Do not remove image shadow root #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
flyingbee2012,
BryanValverdeU,
JiuqingSong,
ianeli1 and
vinguyen12
BryanValverdeU
approved these changes
Nov 29, 2024
juliaroldi
added a commit
that referenced
this pull request
Dec 2, 2024
Do not remove image shadow root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the changes in #2868, images added via drag and drop became uneditable. This issue arises because the attribute in the span of the shadow root was removed, causing the
optimizefunction to remove this span in theremoveUnnecessarySpanfunction. To resolve this, an ID was added to the ImageEdit shadow span to prevent its removal during content model optimization.