Pressing Tab inside a table should select all node contents of the next cell #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
reviewed
Aug 8, 2024
packages/roosterjs-content-model-core/lib/corePlugin/selection/SelectionPlugin.ts
Outdated
Show resolved
Hide resolved
…u/acampostams/select-td-div-on-tab
…u/acampostams/select-td-div-on-tab
Andres-CT98
changed the title
JiuqingSong
reviewed
Sep 3, 2024
packages/roosterjs-content-model-core/lib/corePlugin/selection/SelectionPlugin.ts
Outdated
Show resolved
Hide resolved
| const cellStart = cell.firstChild; | ||
| const cellEnd = cell.lastChild || cell.firstChild; | ||
| // Get first deepest editable position in the cell | ||
| const posStart = normalizePos(cellStart, 0); |
There was a problem hiding this comment.
need null check, in case cellStart/cellEnd is null.
If that happens, maybe we need to create a paragraph? Or just simple put focus into the cell.
There was a problem hiding this comment.
They can not be null.
There was a problem hiding this comment.
We cannot make such assumption. At least we need a null check here or it can throw at runtime.
There was a problem hiding this comment.
The null check is above, after passing it cellStart/cellEnd can not longer be null.
There was a problem hiding this comment.
Oh I see, sorry I missed it.
…u/acampostams/select-td-div-on-tab
JiuqingSong
approved these changes
Sep 5, 2024
JiuqingSong
added a commit
that referenced
this pull request
Sep 6, 2024
* image-selection * fixes * safari fix * fix drag and drop * fixes * fixes * Add `<del>` elements to default processors and use knownElementProcessor for this type of element. (#2770) * init * Use alphabet order * Dont remove the MarginTop/Bottom from lists when pasting from Word Online (#2778) * init * remove unneeded function * try fix build * Reconcile table and image selection for cache (#2714) * Improve cache * fix build * improve * add test * Cache and entity 2 * Add test * Reconcile table and image selection for cache * support reconcile entity delimiter * fix build * add test --------- Co-authored-by: Bryan Valverde U <[email protected]> * Set segmentFormat text color to black when creating the model of the clipboard content and using Keep source formatting paste type (#2773) * init * add a link to tests and make sure it is handled correctly * fixes image in tables * Bump webpack from 5.84.1 to 5.94.0 (#2780) Bumps [webpack](https://github.com/webpack/webpack) from 5.84.1 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.84.1...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Resolve null sheet in convertInlineCss (#2784) * init * update * Update paste code to add a paragraph when the clipboard contains atleast a block element (#2777) * init * add a link to tests and make sure it is handled correctly * init * try fix build * fix build * Fix 300391: [Mail] The numbers will become a continuous sequence after typing enter at the last line of the numbering above (#2782) Co-authored-by: Bryan Valverde U <[email protected]> * Pressing Tab inside a table should select all node contents of the next cell (#2764) * normalise position * revert * empty cell check * select using children * fix tests * fix --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Julia Roldi (from Dev Box) <[email protected]> Co-authored-by: Julia Roldi <[email protected]> Co-authored-by: Bryan Valverde U <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andres-CT98 <[email protected]>
JiuqingSong
added a commit
that referenced
this pull request
Sep 6, 2024
* image-selection * fixes * safari fix * fix drag and drop * fixes * fixes * Add `<del>` elements to default processors and use knownElementProcessor for this type of element. (#2770) * init * Use alphabet order * Dont remove the MarginTop/Bottom from lists when pasting from Word Online (#2778) * init * remove unneeded function * try fix build * Reconcile table and image selection for cache (#2714) * Improve cache * fix build * improve * add test * Cache and entity 2 * Add test * Reconcile table and image selection for cache * support reconcile entity delimiter * fix build * add test --------- Co-authored-by: Bryan Valverde U <[email protected]> * Set segmentFormat text color to black when creating the model of the clipboard content and using Keep source formatting paste type (#2773) * init * add a link to tests and make sure it is handled correctly * fixes image in tables * Bump webpack from 5.84.1 to 5.94.0 (#2780) Bumps [webpack](https://github.com/webpack/webpack) from 5.84.1 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.84.1...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Resolve null sheet in convertInlineCss (#2784) * init * update * Update paste code to add a paragraph when the clipboard contains atleast a block element (#2777) * init * add a link to tests and make sure it is handled correctly * init * try fix build * fix build * Fix 300391: [Mail] The numbers will become a continuous sequence after typing enter at the last line of the numbering above (#2782) Co-authored-by: Bryan Valverde U <[email protected]> * Pressing Tab inside a table should select all node contents of the next cell (#2764) * normalise position * revert * empty cell check * select using children * fix tests * fix * Bump version to 9.10.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Julia Roldi (from Dev Box) <[email protected]> Co-authored-by: Julia Roldi <[email protected]> Co-authored-by: Bryan Valverde U <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andres-CT98 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When Pressing tab to get to the next cell in a table, #2718, in the case of an empty cell the selection should not delete the segment format.
Fix
The selection should not be done using the method selectNodeContents, instead a custom range using the node's first and last child should be done.
Cases tested:
Before: The texts on each cell have different fonts, the first one being the editor default and the second the browser default.
After: The texts of both cells have the same font, being the editor default.